Window CloseAction

[takayser]

Since your last commit, windows can not be closed anymore, just hidden. Why?

[sven]

Close was just a method to release memory if yuo dont want to reuse the window anymore. Now everything gets handled by hide. Windows act now same as any other components.

[takayser]

hmm... what happens if a user works with desktop and open/hide while working more and more windows, will the memory increase with every window if I dont reuse the old hidden ones?

[sven]

Desktop had CloseACtion set to hide

Also when hiding it it gets detached. But you are still holding a reference to it due to the desktop environtment. It is not different than before.

[fredrikhultin]

This crashes things for me though since i relied on setting the Closeaction to close and not to hide. By doing this i created a new window each time and (hopefully) released the old one.

This new behaviour forces med to manually recreate the windows.

Is there any replacement for the Closeaction close functionality?

/fredrik

[sven]

You can simple hide and and create a new one. All memory will get released. It is nothing else than window close before, only that you can now always reuse it and dont have to care about close/hide

[sven]

This crashes things for me though since i relied on setting the Closeaction to close and not to hide. By doing this i created a new window each time and (hopefully) released the old one.

This new behaviour forces med to manually recreate the windows.

You can now also recreate the window same as before. Nothing has changed in this.

[xalvaro]

Why don't you let the close function (doing hide) and tag it deprecated? the same for setIconStyle (doing IconHelper into ).


When you have a big modular application, it's a little bit annoying to have to edit every source code, and i'm not the only one to reproach this.

[sven]

setIconStyle is still there. It internly calls for IconHelper.

[aphahn]

Originally Posted by sven

You can now also recreate the window same as before. Nothing has changed in this.

So why did you break backwards compatability? You could have made close just call hide instead of just making a common api vanish. So, I guess nothing has changed, except you broke the api. Not impressed.