pagingToolbar suggestion

[mjlecomte]

Minor suggestion.

Currently code has:

doLoad : function(start){
var o = {}, pn = this.paramNames;
o[pn.start] = start;
o[pn.limit] = this.pageSize;
if(this.fireEvent('beforechange', this, o) !== false){
this.store.load({params:o});
}
},

Not much point in doing anything if beforechange returns false is there?

doLoad : function(start){
if(this.fireEvent('beforechange', this, o) !== false){
var o = {}, pn = this.paramNames;
o[pn.start] = start;
o[pn.limit] = this.pageSize;
this.store.load({params:o});
}
},

[jgarcia@tdg-i.com]

Minor suggestion.

Currently code has:

doLoad : function(start){
var o = {}, pn = this.paramNames;
o[pn.start] = start;
o[pn.limit] = this.pageSize;
if(this.fireEvent('beforechange', this, o) !== false){
this.store.load({params:o});
}
},

Not much point in doing anything if beforechange returns false is there?

doLoad : function(start){
if(this.fireEvent('beforechange', this, o) !== false){
var o = {}, pn = this.paramNames;
o[pn.start] = start;
o[pn.limit] = this.pageSize;
this.store.load({params:o});
}
},


Eh: :)

o is not defined in your version - when the event fires


:)

[mjlecomte]

Hmph. Too true. :">

Ok, to prevent another blunder for the day.... Is it me or does neither the change nor beforechange events even show up in the docs?

And, while your statement is true, I'm having a hard time imagining how someone would inspect the paramNames and use that to determine if they should return true/false to prevent the page from loading (especially when they could catch it at the beforeload event of the store just as well). I'm all for injection points, just don't see the usage case here (and neither do many others if it undocumented :) ).

[jgarcia@tdg-i.com]

The docs need to be updated. (Nige?) .

I've never used the paging toolbar's events, as I subscribe to the datastore's events as well. :-]

[mystix]

updated in SVN.

do help to review the verbiage -- i added the descriptions before gulping down my morning coffee. ;)

[mjlecomte]

Looks good to me, only comment (without coffee):

The total number of pages which will be returned from the server, based on the current {@link #pageSize}

We don't know if they "will" or not, maybe:

The calculated number of pages based on the current {@link #pageSize} and total number of records.

~o)

[mystix]

good point. changed it to this:

The total number of pages (calculated from the total number of records in the dataset as returned by the server and the current pageSize)