PDA

View Full Version : [FIXED][3.x/2.x] EditorGridPanel::onAutoEditClick


Animal
08-06-2008, 02:41 AM
The config clicksToEdit: 'auto' is undocumented now (I just added the docs for it to SVN), so this bug will not be manifesting (Except for people who read the source who will be able to work around it anyway)

But there's a problem in onAutoEditClick which throws an exception which is handled silently which just aborts editing.

The code should be


onAutoEditClick : function(e, t){
if(e.button !== 0){
return;
}
var row = this.view.findRowIndex(t);
var col = this.view.findCellIndex(t);
if(row !== false && col !== false){
this.stopEditing();
if(this.selModel.getSelectedCell){ // cell sm
var sc = this.selModel.getSelectedCell();
if(sc && sc[0] === row && sc[1] === col){
this.startEditing(row, col);
}
}else{
if(this.selModel.isSelected(row)){
this.startEditing(row, col);
}
}
}
},

Condor
06-25-2009, 01:36 AM
Why is this thread marked as fixed?

It doesn't seem to be fixed in either Ext 2.x or 3.x.

mystix
06-25-2009, 01:49 AM
no idea why the thread was marked [FIXED], but i renamed the thread to read [OPEN] since it's clearly not resolved yet.

evant
06-25-2009, 03:18 AM
Actually fixed. Both branches.