API : MenuItem

[zaccret]

I find the menu item API a little confusing.
We have MenuItem <- Item <- TextMenuItem.
The name choice is confusing (Item <- MenuItem <- TextMenuItem would be more intuitive) and TextMenuItem has no more features than Item.

[gslender]

+1

But perhaps Item could just be refactored to SubMenuItem which is what its purpose and/or name is really??? I don't think Item is used anywhere else???

[darrellmeyer]

Yes, the hierarchy is a little silly :-). I have made the following changes: MenuItem is renamed to Item. Item is renamed to MenuItem. TextMenuItem is removed as it provided no additional features to its super class. The changes are in SVN.

[zaccret]

Nice. Thanks.

[zaccret]

Actually, I think it would be better to rename Item to MenuItem and MenuItem to TextMenuItem.

[sdc]

+1